Skip to content

remove useless LeftOuterSemiJoin Adder #10303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
guo-shaoge wants to merge 1 commit into
base: master
Choose a base branch
from
Open

remove useless LeftOuterSemiJoin Adder #10303

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
83 changes: 0 additions & 83 deletions dbms/src/Interpreters/JoinPartition.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1202,89 +1202,6 @@ void cacheColumns(CachedColumnInfo * cached_column_info, MutableColumns & added_
cached_column_info->state = CachedColumnState::CACHED;
}

template <typename Map>
struct Adder<ASTTableJoin::Kind::LeftOuterSemi, ASTTableJoin::Strictness::All, Map>
{
static bool addFound(
const typename Map::ConstLookupResult & it,
size_t num_columns_to_add,
MutableColumns & added_columns,
size_t i,
IColumn::Filter * /*filter*/,
IColumn::Offset & current_offset,
IColumn::Offsets * offsets,
const std::vector<size_t> & right_indexes,
ProbeProcessInfo & probe_process_info)
{
auto & mapped_value = static_cast<const typename Map::mapped_type::Base_t &>(it->getMapped());
size_t rows_joined = mapped_value.list_length;
bool need_generate_cached_columns = false;
auto * current = &mapped_value;
auto add_one_row = [&]() {
for (size_t j = 0; j < num_columns_to_add - 1; ++j)
added_columns[j]->insertFrom(
*current->block->getByPosition(right_indexes[j]).column.get(),
current->row_num);
};
if unlikely (
probe_process_info.cache_columns_threshold > 0 && rows_joined >= probe_process_info.cache_columns_threshold)
{
assert(mapped_value.cached_column_info != nullptr);
auto check_result = checkCachedColumnInfo(mapped_value.cached_column_info);
need_generate_cached_columns = check_result.second;
if (check_result.first)
{
insertCachedColumns(
mapped_value.cached_column_info,
added_columns,
rows_joined,
num_columns_to_add - 1);
current_offset += rows_joined;
(*offsets)[i] = current_offset;
/// we insert only one row to `match-helper` for each row of left block
/// so before the execution of `HandleOtherConditions`, column sizes of temporary block may be different.
added_columns[num_columns_to_add - 1]->insert(FIELD_INT8_1);
return false;
}
add_one_row();
current = static_cast<const typename Map::mapped_type::Base_t *>(current->cached_column_info->next);
}
for (; current != nullptr; current = current->next)
{
add_one_row();
}
current_offset += rows_joined;
(*offsets)[i] = current_offset;
/// we insert only one row to `match-helper` for each row of left block
/// so before the execution of `HandleOtherConditions`, column sizes of temporary block may be different.
added_columns[num_columns_to_add - 1]->insert(FIELD_INT8_1);

if unlikely (need_generate_cached_columns)
{
cacheColumns(mapped_value.cached_column_info, added_columns, rows_joined, num_columns_to_add - 1);
}
return false;
}

static bool addNotFound(
size_t num_columns_to_add,
MutableColumns & added_columns,
size_t i,
IColumn::Filter * /*filter*/,
IColumn::Offset & current_offset,
IColumn::Offsets * offsets,
ProbeProcessInfo & /*probe_process_info*/)
{
++current_offset;
(*offsets)[i] = current_offset;

for (size_t j = 0; j < num_columns_to_add - 1; ++j)
added_columns[j]->insertDefault();
added_columns[num_columns_to_add - 1]->insert(FIELD_INT8_0);
return false;
}
};

template <ASTTableJoin::Kind KIND, typename Map>
struct Adder<KIND, ASTTableJoin::Strictness::All, Map>
{
Expand Down