DM: Get DB flavor from source instead of guessing it

[dveeden]

What problem does this PR solve?

Issue Number: close #12423

What is changed and how it works?

Check List

Tests

• Manual test (add detailed scripts or steps below)

Questions

Will it cause performance regression or break compatibility?

Do you need to update user documentation, design documentation or monitoring documentation?

Release note

The source database flavor detection has been improved to better handle MariaDB

[gemini-code-assist]

Summary of Changes

Hello @dveeden, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses an issue where the system was incorrectly guessing the database flavor, leading to potential problems with Global Transaction Identifier (GTID) parsing, especially for MariaDB. By explicitly connecting to the source database to determine its flavor, the changes ensure that GTIDs are parsed accurately, improving the robustness and compatibility of data migration processes.

Highlights

• Improved Database Flavor Detection: The system now actively queries the upstream database to determine its specific flavor (e.g., MySQL, MariaDB) instead of relying on assumptions.
• Enhanced GTID Parsing: The detected database flavor is now passed to the GTID parser, allowing for more accurate parsing of Global Transaction Identifiers, particularly beneficial for MariaDB's GTID format.
• Refactored Metadata Parsing: The dumpling.ParseMetaData and dumpling.ParseMetaDataByReader functions have been updated to accept the database flavor, ensuring that metadata files are interpreted correctly based on the source database type.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[dveeden]

/check-issue-triage-complete

[dveeden]

/cc @lance6716 @GMHDBJD

[gemini-code-assist]

Code Review

This pull request aims to improve database flavor detection by actively querying the source database instead of guessing. This is a good improvement for robustness, especially for MariaDB.

However, I've found a couple of critical issues where the new logic could cause a panic due to a nil pointer dereference when a database connection cannot be established. I've provided suggestions to fix these.

Additionally, some code duplication has been introduced. My review includes suggestions to address this for better code quality and maintainability.

[dveeden]

/retest

[dveeden]

/cc @OliverS929

[lance6716]

Please run a manual test after last commit to double check it can work

[ti-chi-bot]

[LGTM Timeline notifier]

Timeline:

• 2025-11-30 11:28:56.68738255 +0000 UTC m=+176481.501160122: ☑️ agreed by lance6716.

[ti-chi-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lance6716

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• dm/OWNERS [lance6716]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[dveeden]

Please run a manual test after last commit to double check it can work

Yes, I did.

[wuhuizuo]

/retest

[ti-chi-bot]

[FORMAT CHECKER NOTIFICATION]

Notice: To remove the do-not-merge/needs-linked-issue label, please provide the linked issue number on one line in the PR body, for example: Issue Number: close #123 or Issue Number: ref #456.

_{📖 For more info, you can check the "Contribute Code" section in the development guide.}

[joechenrh]

/retest

[dveeden]

/retest

[joechenrh]

/retest

[dveeden]

/retest

[ti-chi-bot]

@dveeden: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-dm-integration-test-next-gen	fa6e1c5	link	false	/test pull-dm-integration-test-next-gen

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.