chore: replace deprecated PingCAP download domains#12586
Conversation
|
Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
This cherry pick PR is for a release branch and has not yet been approved by triage owners. To merge this cherry pick:
DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. |
There was a problem hiding this comment.
Code Review
This pull request updates several download URLs across the repository, migrating from the pingcap.org domain to pingcap.com. The review feedback highlights security concerns regarding the use of insecure http protocols for binary downloads and suggests standardizing on https for consistency and safety. Additionally, a minor grammatical correction was suggested for the documentation.
| * `bin/tidb-server` can be downloaded from [tidb-master-linux-amd64](https://download.pingcap.com/tidb-master-linux-amd64.tar.gz) or installed by [tiup](https://github.com/pingcap/tiup), you can use the command `find ~/.tiup -name tidb-server` to locate `tidb-server` binary file and copy it | ||
| * `bin/sync_diff_inspector` # can be downloaded from [tidb-enterprise-tools-latest-linux-amd64](http://download.pingcap.com/tidb-enterprise-tools-latest-linux-amd64.tar.gz) or build from [source code](https://github.com/pingcap/tidb-tools) |
There was a problem hiding this comment.
The download URLs use inconsistent protocols: line 6 uses https while line 7 uses http. For security and consistency, both should use https when downloading executable binaries. Additionally, 'build' should be 'built' for correct grammar.
| * `bin/tidb-server` can be downloaded from [tidb-master-linux-amd64](https://download.pingcap.com/tidb-master-linux-amd64.tar.gz) or installed by [tiup](https://github.com/pingcap/tiup), you can use the command `find ~/.tiup -name tidb-server` to locate `tidb-server` binary file and copy it | |
| * `bin/sync_diff_inspector` # can be downloaded from [tidb-enterprise-tools-latest-linux-amd64](http://download.pingcap.com/tidb-enterprise-tools-latest-linux-amd64.tar.gz) or build from [source code](https://github.com/pingcap/tidb-tools) | |
| * `bin/tidb-server` can be downloaded from [tidb-master-linux-amd64](https://download.pingcap.com/tidb-master-linux-amd64.tar.gz) or installed by [tiup](https://github.com/pingcap/tiup), you can use the command `find ~/.tiup -name tidb-server` to locate `tidb-server` binary file and copy it | |
| * `bin/sync_diff_inspector` # can be downloaded from [tidb-enterprise-tools-latest-linux-amd64](https://download.pingcap.com/tidb-enterprise-tools-latest-linux-amd64.tar.gz) or built from [source code](https://github.com/pingcap/tidb-tools) |
| sync_diff_inspector_download_url="http://download.pingcap.com/tidb-enterprise-tools-nightly-linux-amd64.tar.gz" | ||
| mydumper_download_url="http://download.pingcap.com/tidb-enterprise-tools-latest-linux-amd64.tar.gz" |
There was a problem hiding this comment.
These URLs use http for downloading binaries, which is insecure. Since other parts of the codebase (e.g., dm/tests/tiup/lib.sh) already use https for the same domain and files, these should be updated to https as well.
| sync_diff_inspector_download_url="http://download.pingcap.com/tidb-enterprise-tools-nightly-linux-amd64.tar.gz" | |
| mydumper_download_url="http://download.pingcap.com/tidb-enterprise-tools-latest-linux-amd64.tar.gz" | |
| sync_diff_inspector_download_url="https://download.pingcap.com/tidb-enterprise-tools-nightly-linux-amd64.tar.gz" | |
| mydumper_download_url="https://download.pingcap.com/tidb-enterprise-tools-latest-linux-amd64.tar.gz" |
|
@wuhuizuo: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Summary
download.pingcap.orgreferences withdownload.pingcap.comcharts.pingcap.orgreferences withcharts.pingcap.comwhere presentValidation
git diff --checkdownload.pingcap.org/charts.pingcap.orgreferences in the patched branch