-
Notifications
You must be signed in to change notification settings - Fork 307
tests(ticdc): stop relying on git root for mq compose paths #12607
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
wlwilliamx
wants to merge
2
commits into
pingcap:master
Choose a base branch
from
wlwilliamx:fix/tcpserver-tls-cert-lookup-master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+116
−23
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,68 @@ | ||
| // Copyright 2026 PingCAP, Inc. | ||
| // | ||
| // Licensed under the Apache License, Version 2.0 (the "License"); | ||
| // you may not use this file except in compliance with the License. | ||
| // You may obtain a copy of the License at | ||
| // | ||
| // http://www.apache.org/licenses/LICENSE-2.0 | ||
| // | ||
| // Unless required by applicable law or agreed to in writing, software | ||
| // distributed under the License is distributed on an "AS IS" BASIS, | ||
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
|
|
||
| package framework | ||
|
|
||
| import ( | ||
| "fmt" | ||
| "os" | ||
| "path/filepath" | ||
| "runtime" | ||
| "strings" | ||
| ) | ||
|
|
||
| // ResolveRepoPath returns an absolute path under the tiflow repository | ||
| // without relying on git metadata. This keeps repo-local test assets | ||
| // discoverable from symlinked checkouts and git worktrees. | ||
| func ResolveRepoPath(rel string) (string, error) { | ||
| normalizedRel := filepath.FromSlash(strings.TrimPrefix(rel, "/")) | ||
| for _, base := range repoPathCandidates() { | ||
| dir := base | ||
| for dir != "." && dir != string(filepath.Separator) { | ||
| if isRepoRoot(dir) { | ||
| return filepath.Join(dir, normalizedRel), nil | ||
| } | ||
| parent := filepath.Dir(dir) | ||
| if parent == dir { | ||
| break | ||
| } | ||
| dir = parent | ||
| } | ||
| } | ||
|
|
||
| return "", fmt.Errorf("cannot resolve repo path for %q", rel) | ||
| } | ||
|
|
||
| func repoPathCandidates() []string { | ||
| var candidates []string | ||
| if _, file, _, ok := runtime.Caller(0); ok { | ||
| candidates = append(candidates, filepath.Dir(file)) | ||
| } | ||
| if wd, err := os.Getwd(); err == nil { | ||
| candidates = append(candidates, wd) | ||
| } | ||
| return candidates | ||
| } | ||
|
|
||
| func isRepoRoot(dir string) bool { | ||
| for _, marker := range []string{ | ||
| filepath.Join(dir, "go.mod"), | ||
| filepath.Join(dir, "deployments", "ticdc", "docker-compose"), | ||
| filepath.Join(dir, "tests", "mq_protocol_tests", "framework"), | ||
| } { | ||
| if _, err := os.Stat(marker); err != nil { | ||
| return false | ||
| } | ||
| } | ||
| return true | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,32 @@ | ||
| // Copyright 2026 PingCAP, Inc. | ||
| // | ||
| // Licensed under the Apache License, Version 2.0 (the "License"); | ||
| // you may not use this file except in compliance with the License. | ||
| // You may obtain a copy of the License at | ||
| // | ||
| // http://www.apache.org/licenses/LICENSE-2.0 | ||
| // | ||
| // Unless required by applicable law or agreed to in writing, software | ||
| // distributed under the License is distributed on an "AS IS" BASIS, | ||
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
|
|
||
| package framework | ||
|
|
||
| import ( | ||
| "os" | ||
| "testing" | ||
|
|
||
| "github.com/stretchr/testify/require" | ||
| ) | ||
|
|
||
| func TestResolveRepoPath(t *testing.T) { | ||
| // This regression test verifies repo-local compose assets can be found | ||
| // without invoking git, so worktree and symlinked checkouts stay stable. | ||
| composePath, err := ResolveRepoPath(DockerComposeFilePathPrefix + "docker-compose-avro.yml") | ||
| require.NoError(t, err) | ||
|
|
||
| info, statErr := os.Stat(composePath) | ||
| require.NoError(t, statErr) | ||
| require.False(t, info.IsDir()) | ||
| } |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The current loop condition
dir != "." && dir != string(filepath.Separator)prevents the search from checking the filesystem root (e.g.,/on Unix) or the current directory ifbaseis relative. Sincefilepath.Dirreturns the same path when it reaches the root of the filesystem or the root of a relative path (like.), it is more robust to useparent == diras the termination condition. This ensures that every directory in the hierarchy, including the root, is evaluated byisRepoRoot.