Upgrade github.com/go-sql-driver/mysql to v1.8.1#12633
Conversation
ti-chi-bot
Bot
added
the
release-note-none
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
ti-chi-bot
Bot
added
the
size/XS
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
TestMySQLLogger: v1.8 logs from connection.go instead of packets.go.
ColumnsHolder: v1.8 returns typed values when scanning into *interface{};
scan into *[]byte to preserve the pre-v1.8 []uint8 contract that
downstream codec decoders depend on.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
ti-chi-bot
Bot
added
size/M
Scanning into *[]byte (introduced in b4aa0e2 to preserve the pre-v1.8 []uint8 contract) yields a typed-nil []byte for SQL NULL. Storing that in holder.Values made `value == nil` checks in encodeValue miss NULLs, falling through to `case []byte:` which produced "". Downstream decodeColumn then failed strconv.ParseUint("") and returned nil, panicking in decodeColumns ("cannot decode column"). Fixes TestLargeMessageHandleKeyOnly in pkg/sink/codec/simple. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
/retest |
|
@dveeden: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
1 participant
What problem does this PR solve?
Issue Number: ref #12629
What is changed and how it works?
Separate go-sql-driver/mysql so we can upgrade go-mysql separately.
Check List
Tests
Questions
Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?
Release note