executor: add BroadcastQuery type and update ExecType enum #370
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
0xPoe
force-pushed
the
poe-patch-executor
branch
2 times, most recently
from
698aafb to
ad14d85
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR adds a new broadcast query type to the executor proto and updates the ExecType enum to support distributing SQL commands across TiDB nodes.
- Added a new ExecType enum value "TypeBroadcastQuery".
- Updated the Executor message to include an optional BroadcastQuery field.
- Added a new BroadcastQuery message with a query string field.
0xPoe
commented
May 29, 2025
Member
Author
0xPoe
left a comment
0xPoe
left a comment
There was a problem hiding this comment.
🔢 Self-check (PR reviewed by myself and ready for feedback)
/cc @time-and-fate
time-and-fate
previously approved these changes
May 29, 2025
Signed-off-by: 0xPoe <techregister@pm.me>
…ptorProto size - Updated the descriptor index for BroadcastQuery from 35 to 34. - Replaced the gzipped FileDescriptorProto with a new version, increasing its size from 5470 bytes to 5513 bytes. Signed-off-by: 0xPoe <techregister@pm.me>
…unction - Increased the gzipped FileDescriptorProto size from 5452 bytes to 5497 bytes. - Removed unnecessary conflict markers and cleaned up the init function. Signed-off-by: 0xPoe <techregister@pm.me>
time-and-fate
approved these changes
May 29, 2025
13 tasks
zimulala
added a commit
to zimulala/tidb
that referenced
this pull request
Jun 4, 2025
zimulala
added a commit
to zimulala/tidb
that referenced
this pull request
Jun 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
ref pingcap/tidb#61273
Problem Summary:
What is changed and how it works?
Proposal: pingcap/tidb#61330
What's Changed:
Added a new BroadcastQuery type to help TiDB stats and plan cache modules distribute SQL commands across different TiDB nodes in the cluster.
How it Works:
Related changes
None