Add PMD static analysis with 11 rules and fix all violations#26
Merged
ylecaillez merged 1 commit intopingidentity:mainfrom Mar 26, 2026
Merged
Add PMD static analysis with 11 rules and fix all violations#26ylecaillez merged 1 commit intopingidentity:mainfrom
ylecaillez merged 1 commit intopingidentity:mainfrom
Conversation
Set up maven-pmd-plugin 3.28.0 with PMD 7.22.0 and a curated ruleset covering bug prevention (UnnecessarySemicolon, EmptyCatchBlock, MissingOverride, AvoidPrintStackTrace), code hygiene (UnusedLocalVariable, UnusedPrivateField, UnusedPrivateMethod, UnnecessaryImport), and style (UselessParentheses, UnnecessaryReturn, UnnecessaryModifier). Fix all violations found across the codebase: - Remove stray semicolon in AssertImpl.alwaysOrUnreachable - Add missing @OverRide on DeploymentDescriptor.Source implementations - Remove useless parentheses in Faults, NodeSocketImpl, ReportGenerator - Remove redundant final modifiers in Node (already a final class) - Use unnamed variable _ in catch blocks and pattern bindings - Direct printStackTrace output to err stream in OpenDSTExecutor - Remove duplicate parentheses in TestExecutor - Suppress PMD for record pattern bindings incompatible with Palantir formatter
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Set up maven-pmd-plugin 3.28.0 with PMD 7.22.0 and a curated ruleset covering bug prevention (UnnecessarySemicolon, EmptyCatchBlock, MissingOverride, AvoidPrintStackTrace), code hygiene (UnusedLocalVariable, UnusedPrivateField, UnusedPrivateMethod, UnnecessaryImport), and style (UselessParentheses, UnnecessaryReturn, UnnecessaryModifier).
Fix all violations found across the codebase: