Fix non-determinism from platform thread shutdown hooks#27
Merged
ylecaillez merged 1 commit intopingidentity:mainfrom Apr 10, 2026
Merged
Fix non-determinism from platform thread shutdown hooks#27ylecaillez merged 1 commit intopingidentity:mainfrom
ylecaillez merged 1 commit intopingidentity:mainfrom
Conversation
Node.addShutdownHook() now skips hooks backed by platform threads (e.g. JUL's LogManager$Cleaner) with a logLifecycle warning, since platform threads cannot run deterministically inside the simulation. New it-thread integration test forces LogManager initialization inside the simulation (triggering LogManager$Cleaner hook registration), verifies determinism via 50% replay probability, and asserts the guard fires by replaying a plan and checking for the lifecycle message.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Node.addShutdownHook() now skips hooks backed by platform threads (e.g. JUL's LogManager$Cleaner) with a logLifecycle warning, since platform threads cannot run deterministically inside the simulation.
New it-thread integration test forces LogManager initialization inside the simulation (triggering LogManager$Cleaner hook registration), verifies determinism via 50% replay probability, and asserts the guard fires by replaying a plan and checking for the lifecycle message.