Detect platform threads started inside simulation context#28
Merged
ylecaillez merged 1 commit intopingidentity:mainfrom Apr 10, 2026
Merged
Conversation
Add ThreadStartAdvice on Thread#start() that logs a lifecycle warning when a platform thread is started inside a simulation. Platform threads escape deterministic scheduling and are a source of non-determinism (e.g. Netty's GlobalEventExecutor spawning FastThreadLocalThread). Pre-initialize VirtualThread in premain() to ensure the JDK's VirtualThread-unblocker platform thread is created before any simulation runs, avoiding a false positive from the new guard. Extend it-thread to verify no platform thread starts leak into the simulation replay output.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add ThreadStartAdvice on Thread#start() that logs a lifecycle warning when a platform thread is started inside a simulation. Platform threads escape deterministic scheduling and are a source of non-determinism (e.g. Netty's GlobalEventExecutor spawning FastThreadLocalThread).
Pre-initialize VirtualThread in premain() to ensure the JDK's VirtualThread-unblocker platform thread is created before any simulation runs, avoiding a false positive from the new guard.
Extend it-thread to verify no platform thread starts leak into the simulation replay output.