fix: canMerge implementation#1
Merged
guyutongxue merged 5 commits intoJun 3, 2026
Merged
Conversation
Copilot created this pull request from a session on behalf of
guyutongxue
June 2, 2026 15:41
View session
guyutongxue
changed the title
There was a problem hiding this comment.
Pull request overview
Fixes source-map segment merging so adjacent mappings are merged correctly even when the mapping does not start at source offset 0, and updates/extends tests to cover the corrected behavior and resulting mapping shapes.
Changes:
- Correct
canMergeadjacency logic to compare end/start offsets directly. - Add a regression test for merging adjacent mappings with non-zero source offsets.
- Update existing mapping assertions impacted by the new merging behavior.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
test/printer.test.ts |
Adds/updates tests to validate the corrected mapping merge behavior and the resulting merged mapping segments. |
src/mappings.ts |
Fixes canMerge so pushMapping can merge truly adjacent source/generated segments. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
61
to
64
| return ( | ||
| left.sourceStart + left.sourceEnd === right.sourceStart && | ||
| left.generatedStart + left.generatedEnd === right.generatedStart | ||
| left.sourceEnd === right.sourceStart && | ||
| left.generatedEnd === right.generatedStart | ||
| ); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request created by AI Agent