Skip to content

Sol v0.8#21

Open
RyanRHall wants to merge 5 commits intopipermerriam:masterfrom
smartcontractkit:master
Open

Sol v0.8#21
RyanRHall wants to merge 5 commits intopipermerriam:masterfrom
smartcontractkit:master

Conversation

@RyanRHall
Copy link
Copy Markdown

@RyanRHall RyanRHall commented Oct 20, 2021

This PR does the following:

  • upgrades the DateTime contract to sol v0.8
  • introduces brownie as a dependency for running tests locally
  • adds a CI workflow to hopefully make future changes easier to manage

@pipermerriam
Copy link
Copy Markdown
Owner

Should I expect the CI workflow to run in this PR? I did a quick check of permissions and it seems it should be running.

Comment thread .github/workflows/ci.yml Outdated
@@ -0,0 +1,20 @@
name: "CI"
on:
push:
Copy link
Copy Markdown

@lightclient lightclient Oct 20, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe a typo? usually i see this as on: [push]

@RyanRHall
Copy link
Copy Markdown
Author

@pipermerriam I'm guessing we're not seeing the CI runs because the PR is cross-repository. Probably some github policy. When I make PRs onto our fork of the repo, CI works fine.

If you want to see the CI run before merging, you'll probably have to pull this branch, push up a local copy, and open a new PR.

@RyanRHall
Copy link
Copy Markdown
Author

Copy link
Copy Markdown
Owner

@pipermerriam pipermerriam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets see if this enables the workflow?

@lightclient
Copy link
Copy Markdown

Maybe try to rename ci.yml to ci.yaml?

@RyanRHall
Copy link
Copy Markdown
Author

Maybe try to rename ci.yml to ci.yaml?

CI works fine. It's just disabled for outside contributors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants