Conversation
|
Should I expect the CI workflow to run in this PR? I did a quick check of permissions and it seems it should be running. |
| @@ -0,0 +1,20 @@ | |||
| name: "CI" | |||
| on: | |||
| push: | |||
There was a problem hiding this comment.
maybe a typo? usually i see this as on: [push]
fix workflow typo
|
@pipermerriam I'm guessing we're not seeing the CI runs because the PR is cross-repository. Probably some github policy. When I make PRs onto our fork of the repo, CI works fine. If you want to see the CI run before merging, you'll probably have to pull this branch, push up a local copy, and open a new PR. |
|
According to github, you should be able to "approve and run" @pipermerriam |
pipermerriam
left a comment
There was a problem hiding this comment.
lets see if this enables the workflow?
|
Maybe try to rename |
CI works fine. It's just disabled for outside contributors. |
This PR does the following: