Add support for uses_kubernetes_features metadata - #667
Open
ystros wants to merge 1 commit into
Open
Conversation
uses_kubernetes_features is a new tile attribute that allows K8s consumer tiles to restrict which K8s distribution tiles can be assigned to it by matching those features against the distribution's features. This commit updates `kiln carvel bake` to pass through the new attribute. ai-assisted=yes [TNZ-120804] Define available_kubernetes_features / uses_kubernetes_features tile metadata schema
There was a problem hiding this comment.
Pull request overview
Adds pass-through support for the new uses_kubernetes_features tile metadata attribute in the Carvel baker flow, allowing baked K8s consumer tiles to express required/optional Kubernetes features in their output metadata.
Changes:
- Extends Carvel metadata models (
Metadata,MetadataOut) to includeuses_kubernetes_features. - Updates
kiln carvel bakebase.yml generation to copyuses_kubernetes_featuresfrom input to baked output. - Expands baker tests (and sample tile testdata) to validate both presence and omission behavior for
uses_kubernetes_features.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| internal/carvel/testdata/sample-tile/base.yml | Adds uses_kubernetes_features examples used by bake tests. |
| internal/carvel/models/metadata.go | Adds UsesKubernetesFeatures to the input metadata model. |
| internal/carvel/models/metadata_out.go | Adds UsesKubernetesFeatures to baked output metadata and introduces KubernetesFeature type. |
| internal/carvel/baker.go | Copies UsesKubernetesFeatures into generated base.yml. |
| internal/carvel/baker_test.go | Verifies correct baking of features and omission when absent in input metadata. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
uses_kubernetes_features is a new tile attribute that allows K8s consumer tiles to restrict which K8s distribution tiles can be assigned to it by matching those features against the distribution's features. This commit updates
kiln carvel baketo pass through the new attribute.ai-assisted=yes
[TNZ-120804] Define available_kubernetes_features / uses_kubernetes_features tile metadata schema