refactor: try moving several utility implementations to a new package @pixiv/three-vrm-utils#1153
Conversation
Contributor
Author
|
なんでビルド通らないんだ |
… `@pixiv/three-vrm-utils`
"add a cache path for the new package" is a stale instruction from the CircleCI era
Contributor
Author
|
あーーー、yarn.lockのdiffがないからキャッシュが腐ってるのかな。yarn.lockにダミー行追加してみました |
Contributor
Author
|
あたり～ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Moved several utility implementations to a new package
@pixiv/three-vrm-utils.As the README of the package says, it's mainly intended to be internal utilities.
It's a similar way to how charcoal manages its utility functions.
Also, I found several utility functions that are not referenced anywhere, so I removed them.
Points need review