fix: add missing aria-label to copy button in hero-code.tsx#482
fix: add missing aria-label to copy button in hero-code.tsx#482narutamaaurum wants to merge 1 commit into
Conversation
Addresses issue piyushdotcomm#463 - screen readers now announce 'Copy code' or 'Copied to clipboard' based on button state.
Qodo reviews are paused for this user.Troubleshooting steps vary by plan Learn more → On a Teams plan? Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center? |
👋 Thanks for opening a PR, @narutamaaurum!Your PR has entered the 🚦 PR Review Pipeline.
What happens next
A pipeline status comment will appear below and update automatically as your PR progresses. While you wait
This comment is posted only once. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
WalkthroughThe copy button in the homepage hero code demo now includes a dynamic ChangesCopy button accessibility
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Fixes #463 - Missing aria-label on copy button in hero-code.tsx
The copy button in the homepage hero code demo contained only icon children with no attribute. Screen readers announced it as an unlabeled interactive element ('button' with no name).
This fix adds a dynamic that communicates both the action and the state:
This matches the pattern already used in other components (issues #283, #281, #279).
Summary by CodeRabbit