Skip to content

Hire preflight: refuse a run when the tank is too weak or the hire faction does not match the plan's team; hire at the portal ground #266

Open

Description

@pjerra

Found in the 2026-10-20 full observer runs (ZF #257, RFC #258, Uldaman #261, WC); data in ~/TortoiseBots-audit/tests/full-obs-*-19z16/, lessons entries zf/rfc/uldaman/wc-full-19z16 in RUN-LESSONS.md, analysis ~/TortoiseBots-audit/RFC-DEATHS-ANALYSIS.txt. Module code is Sagiroth/TortoiseBots feat/dungeon-self-clear (ours to merge into); tracked here.

Evidence: RFC tank had 641 max HP (item level 14.0, 7 white items) vs 901 on 10-17 (19.5, 5 blue): the same step-34 pull nearly killed the strong one (158/901). The first RFC setup (attempt 2a) wiped all 5 hires in 41 s: Alliance commander hires Alliance bots for a team=horde plan and the muster at the login point z -19.8 under the portal walked into an Orgrimmar Grunt (lvl 55) and an imp. Fix: preflight checks (agent/dungeon): tank max HP floor per dungeon level band (a table, e.g. 800 at level 16 for RFC, warn below, refuse well below), hire gear (autogear again or re-roll within the free-hire tool), a faction check against the plan's team, and hire/enter only from the ground at the portal (z -10.4) or via cmd enter without the door walk when everyone is within ~30 yd of the trigger. Related: #253.

Activity

  1. pjerra commented on Oct 23, 2026

    @pjerra
    OwnerAuthor

    First slice merged in #298: the plan field tank_min_hp (RFC 800) and two preflight warnings, one for a tank below the floor and one for a bot whose race belongs to the other team than the party's (the run's team option, else the agent's race; bots out of view are skipped and counted). The check runs before .bot maintenance moves the hires. Strict preflight fails the run on either. Still open: refusing to hire or enter at hazard spots, tank floors for the other dungeons, and making the free-hire tool hire the commander's faction (module side).

  2. self-assigned this
    on Oct 25, 2026
  3. pjerra commented on Oct 28, 2026

    @pjerra
    OwnerAuthor

    Status 2026-10-28

    Done: first slice merged in #298: plan field tank_min_hp plus two warnings (low tank HP, hire from the other faction).

    Still open:

    • tank_min_hp is set only for Ragefire Chasm (dungeons/ragefire_chasm.json, 800); the other plans need values.
    • Refusing to hire or muster at a hazard spot (e.g. under the portal).
    • A faction-safe hire on the module side.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions