Repository navigation
Observe: count the lead bot's deaths and revives, and a wipe spread over 90 s (#264) - #294
Merged
Merged
Conversation
An observed run's report read 0 leader deaths and resurrections: only the group-mode driver counted them. The observe watch now follows the party's deaths in the feed, counts the lead bot's deaths and revives (report, legs, leader_death trace events, seconds dead), and counts a wipe when every member died within 90 s even though the lead bot revived in between, each death newer than the last counted wipe (the RFC run: all five dead within 63 s, never in one frame).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #264 (agent side).
Observe runs now count the lead bot's deaths and revives, and a wipe spread over time:
leader_deaths,resurrectionsandseconds_dead, with aleader_deathtrace event."window": true. A guard prevents a second count with the all-dead latch, and a lone death after a counted window wipe does not count again.Tests: four observe tests (lead death and revive, a spread-out wipe, deaths outside the window, no double count) plus
TestObserveNoSecondWipeFromALoneDeathAfterAWindowWipe; mutations of each rule turn a test red.go test ./...andgo vet ./...pass.Reviews: Opus cold review SHIP; Codex review: one P2 kept as a known limit (below).
Known limits:
seconds_dead.Still open on #264: the module-side record of leader deaths and wipes (TortoiseBots), the Uldaman near-wipes, and a fixture test from the real RFC trace.