Repository navigation
Observe: count the run leader's rest phases and expose the instance id (#271 A+B) - #295
Merged
Merged
Conversation
A paused TBM:RUN line still carries the phase it paused in, so a run paused in the rest phase kept its rest open and the whole pause (PausedWait, 10 min) went into rest_seconds and rest_share. The rest is now open only while the run is running in phase rest; any other state closes it, and a resume in the same phase opens a new one. The new test fails at 290 s rest without the state check and passes at 10 s with it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #271 (parts A and B).
rest) as rest gates (resultrun_leader), withresttrace events ("source": "run_leader"),rest_seconds,rest_shareand per-leg totals. A rest still open at the end of the run is closed and counted. Paused time is not counted as rest: a rest is open only while the run is running.report.instance, aninstancetrace event and the summary'sinstance.Tests: six observe/trace tests, each failing before the change (rest seconds 0, rest gates empty, instance 0, paused time counted as rest); mutations of each rule turn a test red.
go test ./...andgo vet ./...pass.Reviews: Opus cold review (one fix found: paused time counted as rest, fixed in d3c8081), Codex review of the fix clean.
Known limits: a rest before the first leg status adds to
rest_secondsbut to no per-leg total; group/leader-mode drivers do not expose the instance id yet.Still open on #271: part C, the botwatch sampler that exits silently (wow-play-harness).