Repository navigation
trace-score: taunt latency, long-CC hold and pet threat in the spells check (#289 T-c) - #297
Merged
Merged
Conversation
cc_hold joins only long crowd control (the short stuns end unflagged and read as broken holds) and a mob killed while flagged is not broken. A taunt with a target answers only that mob's episode.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #289 (T-c).
The
spellscheck of trace-score gets three warning-only readings (the verdict stays Pass), each settable with--set:taunt_latency: median time from a mob leaving the tank to the tank taking it back (warns over 3 s, from 3 episodes). A taunt is credited only to the episode of the mob it targets when the target is known; only the tank's taunts count; an episode open when the tank dies is not counted.cc_hold: share of long crowd control that held (warns under 50 %, from 3 episodes). Long CC only: Polymorph, Sap, Shackle Undead, Freezing Trap, Banish, Hibernate, Seduction, Blind, Fear, Turn Undead, Entangling Roots; short stuns are not joined. A mob that dies while controlled is not counted as broken.pet_threat: share of mob-frames where a pet holds top threat (warns over 5 %, from 30 frames).Smoke on a real Zul'Farrak trace: taunt latency median 5.2 s over 122 episodes, CC held 47 %, pet threat 2.5 %.
Tests: taunt latency, CC hold, pet threat, settable limits and the report lines, plus cases for a pet holding threat, a tank death mid-episode, a healer's taunt, a short stun, a CC'd mob dying, a targeted taunt and Entangling Roots; each guard was removed once and its test went red.
Reviews: Opus cold review (fixes: short stuns, dead-first check, missing tests), Codex review (taunt target matching; Entangling Roots), both addressed.
Still open on #289: T-b (server-side run trace on the test box needs an owner config decision and round scripts that copy it back) and oom_in_fight as a warning.