Repository navigation
Observe: record player-order pauses and their resume (#270 agent side) - #299
Merged
Merged
Conversation
A paused status whose note says the module paused for a player order (the observer's own cmd summon, a move) is now in report.remote.observe.player_orders with the step and the order; controls also records the player order and the resume after it. The module's own note addenda count once.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #270 (agent side).
The observe report now lists each pause the run leader makes for a player's order in
report.remote.observe.player_orders(step and order);controlsrecordsplayer order: ...and, when the run resumes,resumed after the player order; aplayer_ordertrace event is written. A pause that ends in a stop records no resume. The agent sends nothing new to the server.Tests: the order pause and its resume, a repeated note counted once, a pause ending in a stop with no resume; mutations turn them red.
go test ./...passes.Reviews: Opus cold review (one fix: done counted as a resume), Codex review clean after the fix.
Still open on #270: the module side (TortoiseBots PauseForPlayer): whether a
cmd summonduring a run should skip the pause or resume by itself is a module decision.