Skip to content

Add profile for Ministry of Finance#671

Open
vanbroup wants to merge 1 commit into
mainfrom
mof-profile
Open

Add profile for Ministry of Finance#671
vanbroup wants to merge 1 commit into
mainfrom
mof-profile

Conversation

@vanbroup

@vanbroup vanbroup commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

Automatically generated pull request to add profile for Ministry of Finance according to application pkic/members#798.

This closes pkic/members#798

@vanbroup vanbroup added automated pr member profile Member profile related labels Jul 3, 2026
@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Jul 3, 2026

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
pkic-org d7b5d72 Commit Preview URL

Branch Preview URL
Jul 03 2026, 01:48 PM

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a new member configuration file for the Ministry of Finance (Egypt). The feedback recommends removing the empty sponsor block to prevent Hugo build errors and stripping the tracking parameter from the Instagram URL to ensure a clean link.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread data/members/mof.yaml
Comment on lines +20 to +22
# sponsor
sponsor:
level:

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The empty sponsor block should be completely omitted. Leaving it in with an empty level and no sponsoring key will cause Hugo's index function to fail with a build error (error calling index: value is nil; should be of type string or index of untyped nil) when evaluating index .sponsoring $site.Params.name in layouts/partials/members/card.html.

Comment thread data/members/mof.yaml
social:
x: https://twitter.com/MofEgypt
facebook: https://www.facebook.com/MOF.Egypt
instagram: https://instagram.com/mofegypt?igshid=k40zpext9mir

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The Instagram URL contains a tracking parameter (?igshid=k40zpext9mir). It is best practice to remove tracking parameters from URLs to keep them clean and protect user privacy.

  instagram: https://instagram.com/mofegypt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automated pr member profile Member profile related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant