rbac modifications for permission issues#117
Open
bilalcaliskan wants to merge 2 commits intoplanetlabs:masterfrom
Open
rbac modifications for permission issues#117bilalcaliskan wants to merge 2 commits intoplanetlabs:masterfrom
bilalcaliskan wants to merge 2 commits intoplanetlabs:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #117 +/- ##
=======================================
Coverage 75.58% 75.58%
=======================================
Files 7 7
Lines 471 471
=======================================
Hits 356 356
Misses 101 101
Partials 14 14 Continue to review full report at Codecov.
|
Author
|
Hello @jacobstr , can you review the changes please :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #92 and #51. There are couple of duplicated issues for that problem.
Draino fails when deployed with the manifest.yml in the repository. I have fixed the missing verbs in
ClusterRole.I have also fixed the golangci-lint error while linting the code.