helm: allow multiple values for node-label flag#65
Open
morpheu wants to merge 1 commit intoplanetlabs:masterfrom
Open
helm: allow multiple values for node-label flag#65morpheu wants to merge 1 commit intoplanetlabs:masterfrom
morpheu wants to merge 1 commit intoplanetlabs:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #65 +/- ##
=======================================
Coverage 85.41% 85.41%
=======================================
Files 6 6
Lines 288 288
=======================================
Hits 246 246
Misses 40 40
Partials 2 2Continue to review full report at Codecov.
|
Contributor
|
Thanks for this! I believe existing chart users may be broken here if they used singular Side node - It might be worth updating the documentation in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR allow pass multiple values for
node-labelarg. Now when specifynode-labelonextraArgsit's a list instead string. Eg: