Quote ${CLAUDE_PLUGIN_ROOT} in hook commands (fixes hooks on paths with spaces)#62
Quote ${CLAUDE_PLUGIN_ROOT} in hook commands (fixes hooks on paths with spaces)#62Seph396 wants to merge 1 commit into
Conversation
The bun-run hook commands in plugins/honcho/hooks/hooks.json use an
unquoted ${CLAUDE_PLUGIN_ROOT}, so they break when the plugin root path
contains a space — which is the default macOS Claude Desktop location
(~/Library/Application Support/Claude/...). Wrap the path in double
quotes on all 8 commands, matching the already-quoted check-version line.
Fixes plastic-labs#61
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughThis pull request fixes hook execution failures on systems where the plugin root path contains spaces. All eight hook definitions in ChangesHook path quoting for space-safe shell invocation
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Fixes #61.
The
bun runhook commands inplugins/honcho/hooks/hooks.jsonreference${CLAUDE_PLUGIN_ROOT}unquoted, so the shell word-splits the path when it contains a space. On macOS the default Claude Desktop plugin location is under~/Library/Application Support/Claude/…(note the space), so the hooks silently fail to fire for that install class — no Honcho capture, often a confusing/empty error.This wraps
${CLAUDE_PLUGIN_ROOT}in double quotes on all 8 commands, matching thecheck-version.shcommand which was already quoted. No behavior change for space-free paths.JSON validated after the change.
Summary by CodeRabbit