Conversation
This was
linked to
issues
Oct 25, 2025
Closed
- Add godox and gosec linters to golangci configuration - Improve HTTP server security by adding ReadHeaderTimeout - Enhance file permission security in code generation: - Change directory permissions from 0755 to 0750 - Change file permissions from 0644 to 0600 - Add path cleaning for template paths to prevent directory traversal
The filepath.Clean call was redundant since the template path is constructed using filepath.Join which already handles path normalization. Additionally, added a gosec linter exception comment since the template path is known at compile time and safe.
- Add makezero linter to detect zero-length slice declarations - Add mirror linter for code consistency improvements - Refactor test code to use WriteString instead of Write with byte slice conversion
- Add musttag, nestif, nilerr, nilnesserr, and nilnil linters to golangci configuration - Refactor authentication middleware to properly handle user not found errors - Replace nil user check with explicit ErrUserNotFound error handling in service layer - Improve error response consistency in authentication flow
Add nil check before closing response body in test defer function to prevent potential nil pointer dereference when response body is nil.
fix(httpclient): add nil check for response body in test
- Add 'paralleltest' linter to golangci configuration to enforce parallel test usage - Add t.Parallel() to all test functions in auth, httpclient, and httpserver packages - Remove unnecessary response body cleanup in httpclient error test case - Enable parallel execution for improved test performance and better resource utilization
- Standardize struct tag ordering in User and Session structs to have db tags before json tags - Add staticcheck and tagalign linters to golangci configuration - Update linter configuration comments for better maintainability
- Add tagliatelle, testableexamples, testpackage, thelper, tparallel, unconvert, unparam, unused, and usestdlibvars linters to golangci configuration - Configure tagliatelle to enforce camelCase for JSON tags - Replace string literals with http.Method constants in test files for improved code quality and consistency - Update HTTP method usage in auth middleware and httpclient tests to use standard library constants
- Add usetesting, wastedassign, and wrapcheck linters to golangci configuration - Enhance error handling across multiple packages by wrapping errors with context - Improve error messages in auth, database, httpclient, httpserver, scheduler, and session packages - Ensure consistent error wrapping pattern throughout the codebase
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.