Skip to content

Conversation

@tjementum
Copy link
Member

Summary & Motivation

Stabilize end-to-end tests by fixing cross-browser timing issues and improving test patterns. The test suite now passes consistently across Chromium, Firefox, and WebKit browsers.

Browser-specific fixes:

  • Fix OTP typing reliability in Firefox and WebKit by using direct event dispatching with microtask yields between characters, allowing React state updates to propagate before the next keystroke
  • Add browser-specific auth state paths to prevent cross-browser test isolation failures when running tests in parallel
  • Fix WebKit auth validation race condition in ownerPage fixture by waiting for network idle before checking URL

Revert Rsbuild runtime error overlay:

  • Remove the recently added Rsbuild runtime error overlay feature that was causing false positive test failures
  • The overlay catches benign ResizeObserver loop completed warnings (especially common in Firefox) and displays a blocking full-screen error
  • Rsbuild does not support filtering runtime errors (unlike Rspack), making it impossible to show the overlay for real errors while hiding benign warnings

Code quality improvements:

  • Replace useEffect toast anti-pattern with onSuccess callbacks in mutation handlers
  • Add pending state text feedback to invite user submit button
  • Update frontend rules with toast timing and dirty modal patterns

Test infrastructure:

  • Add flaky test tracking skill for systematic E2E failure logging
  • Update QA review workflow to run full regression test suite before commit

Checklist

  • I have added tests, or done manual regression tests
  • I have updated the documentation, if necessary

@tjementum tjementum self-assigned this Jan 14, 2026
@tjementum tjementum requested a review from a team as a code owner January 14, 2026 18:42
@tjementum tjementum added the Bug Something isn't working label Jan 14, 2026
@linear
Copy link

linear bot commented Jan 14, 2026

@sonarqubecloud
Copy link

@tjementum tjementum merged commit d4c3b6e into main Jan 14, 2026
23 checks passed
@tjementum tjementum deleted the pp-765-stabilize-flaky-e2e-tests branch January 14, 2026 19:05
@github-project-automation github-project-automation bot moved this to ✅ Done in Kanban board Jan 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug Something isn't working

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants