Repository navigation
feat(desktop): Watch Together on the desktop (phase 3) - #534
Open
playbridgeapp wants to merge 3 commits into
Open
playbridgeapp wants to merge 3 commits into
playbridgeapp wants to merge 3 commits into
Conversation
- Dart binding for pb_together_* in playbridge_cast_core - Watch Together screen: start or join, show a code for a phone, party controls - the party drives the desktop player; play, pause and seek go to the party - a paired phone can add the Mac (watch_together_join), and the Mac can add its connected PlayBridge TV - extension casts during a party play in the party - desktop builds include the together feature
…pause - the leader pauses the party once no device shows the video, and a video waits for a screen before it starts - live streams (loaded with no length) share only playing or paused: no seeks or speed nudges - rebuild the phone and TV native libraries
- a TV that isn't told in time whether a video is live uses its known length - live parties don't pause for a buffering device; play after a pause jumps every device to its live point (go_live), on ExoPlayer and mpv - the room announces live parties; phone and desktop party screens hide seeking, and seeks are refused - rebuild the phone, TV and desktop native libraries
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Phase 3 of Watch Together (
docs/design-watch-together.md): the desktop as a screen, a remote and a host. Stacked on #533; retarget tomainonce #533 merges.Desktop
watch_together_v1; the Rust receiver passes an authenticated sender'swatch_together_jointo the app, which joins and answerswatch_together_joinedwith its member ID and keys.pb_together_*inpackages/playbridge_cast_core_dart; desktop builds (script and PR CI) include thetogetherfeature.Engine (all platforms)
go_live: ExoPlayer default position, mpvseek 100 absolute-percent; newseekToLiveon the TV renderer interface).Tests