The roadmap said one drill was behind the membership. Two are. - #100
Open
pip-robot[bot] wants to merge 1 commit into
Open
The roadmap said one drill was behind the membership. Two are.#100pip-robot[bot] wants to merge 1 commit into
pip-robot[bot] wants to merge 1 commit into
Conversation
The 26 August correction to "How Pip pays for itself" fixed the claim that the membership was not built, and introduced a smaller one in the same paragraph: it said one drill kind sits behind the entitlement check. `count-your-outs` and `pot-odds` both carry `membersOnly` in `src/config/drills.ts`, and both have since 25 August. Names the two kinds instead of counting them, so the next kind does not make this false again, and says plainly that this is the second correction to a section whose whole job is to be checkable.
Deploying pip-web with
|
| Latest commit: |
d8eee1e
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://83d65a0a.pip-web-9oj.pages.dev |
| Branch Preview URL: | https://fix-roadmap-said-one-drill-w.pip-web-9oj.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ROADMAP.mdsays the membership check is live and "since 25 August one drill kind sits behind it." Two do.src/config/drills.tscarriesmembersOnly: trueoncount-your-outsandpot-odds, and has since 25 August: outs at 08:04 UTC, pot odds at 15:31 UTC. The 26 August correction (#96) was written between those two facts landing and counted one of them.Why it matters more than a miscount usually would. That paragraph ends with "if that ever stops being true, this section is where you'd catch us", and it is the document our public answer to "how do you make money" points at. A number that is wrong in the paragraph whose job is to be checkable is the one place we cannot afford a rounding error.
The fix names the kinds instead of counting them, so a third gated kind does not make it false again, and it says out loud that this is the second correction to the same section rather than quietly resetting the counter.
Nothing else changes: no price, no
/membership, no way to pay, no date. Both routes still return 200 to a signed-out visitor and still say "This one comes with the membership".Gate:
pnpm test:allandpnpm buildgreen. One file.Found while closing marketing #81, the launch-day money answer, which is moot now that the launch is over.