test(ai): correct two mistyped figures in the ladder comments - #103
Open
pip-robot[bot] wants to merge 1 commit into
Open
test(ai): correct two mistyped figures in the ladder comments#103pip-robot[bot] wants to merge 1 commit into
pip-robot[bot] wants to merge 1 commit into
Conversation
Both were transcription slips when the tables were written, not drift. Re-measured on v1.18.0: riverboat enters as a raiser 40.8% of the time (41%, not 42%), and the 150-hand sample-size spread tops out at 12.6, not 12.9. Every other figure reproduces exactly. Proven not to be drift rather than assumed: policy.ts changed since #88 (the postflop fair-share work in #98), but every preflop branch in it is byte-identical and venues.ts is unchanged, and the measurement stops at the preflop betting round closing. Also marks the ladder table as a dated snapshot. It is documentation of a run, not a live assertion, and this issue exists because hand-typed numbers in this file went stale once already.
Deploying pip-web with
|
| Latest commit: |
4343dd8
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://65ef04f6.pip-web-9oj.pages.dev |
| Branch Preview URL: | https://fix-ai-test-comment-figures.pip-web-9oj.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closing the loop on technology#68. #88 fixed the real defect (the band tests read
ALL_VENUESinstead of a retyped copy of three rungs). Re-verifying its numbers on today'smainfound two digits in that file's own comments that were mistyped when I wrote them.What is wrong
riverboat 42%. Re-measured it is 40.8%, so 41%.9.0-12.9. Re-measured it tops out at 12.6.Every other figure in the file reproduces exactly: the ten-rung entries-raised table (32 / 41 / 46 / 48 / 40 / 41 / 43 / 45 / 51 / 60), VPIP 35.2% at the Garage down to 19.0% at the Main Event, and the 18-hand spread 18.4 / 3.4 / 10.7 / 6.0 / 4.8.
These are slips, not drift, and that is checked rather than assumed
src/lib/poker/ai/policy.tshas changed since #88 merged (the postflop fair-share work in #98), so "the numbers moved" was the obvious suspect. It is not what happened:preflop ? ...branch inpolicy.tsis byte-identical to the test(ai): measure the preflop bands against every shipped venue #88 merge commit (0a99172). The whole diff is the postflop gates.src/config/venues.tsis unchanged since that commit.So no public claim moves. "The ladder gets more aggressive as stakes climb" and "up to The Main Event" still hold, with the same margins, and the shape assertions were green throughout.
Also
The ladder table is now marked as a dated snapshot rather than reading as current truth. The assertions below it are the shape and they print the live table on failure. technology#68 exists because hand-typed numbers in this file went stale once already, so a comment that looks like a measurement should say when it was one.
Gate
pnpm test:allgreen (550 tests),pnpm buildgreen. Comment-only change to a test file, so there is nothing UI-shaped in it, and there is no browser here either way.