Skip to content

Allow passing command-line arguments to go_test targets #368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
toastwaffle merged 5 commits into from
Jul 21, 2026
Merged

Allow passing command-line arguments to go_test targets #368

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
b4047be
Add __TEST_ARGS__ to go_test test_cmd
chris-franklin Jul 10, 2026
2cd2885
Set test_cmd_args_placeholder and update version and changelog
chris-franklin Jul 17, 2026
0feb636
Update required please version
chris-franklin Jul 17, 2026
366087f
Put PR number in release notes
chris-franklin Jul 17, 2026
c041331
Update required please version for e2e plugin
chris-franklin Jul 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .plzconfig
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
[Please]
Version = >=17.21.0
Version = >=17.31.0

[build]
hashcheckers = sha256
Expand All @@ -20,7 +20,7 @@ Target = //plugins:cc

[Plugin "e2e"]
Target = //plugins:e2e
PleaseVersion = 17.21.0
PleaseVersion = 17.31.0

[PluginDefinition]
Name = go
Expand Down
4 changes: 4 additions & 0 deletions ChangeLog
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
Version 1.32.0
--------------
* Allow passing command-line arguments to go_test targets (#368)

Version 1.31.1
--------------
* Fix bug in 1.31.0 where the plugin was still referencing the last version of `please_go`
Expand Down
2 changes: 1 addition & 1 deletion VERSION
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
1.31.1
1.32.0
3 changes: 2 additions & 1 deletion build_defs/go.build_defs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -879,7 +879,7 @@ def go_test(name:str, srcs:list, resources:list=None, data:list|dict=None, deps:
cmds, tools = _go_binary_cmds(name, static=static, definitions=definitions, gcov=cgo, test=True)


test_cmd = f'$TEST {flags} 2>&1 | tee $TMP_DIR/test.results'
test_cmd = f'$TEST {flags} __TEST_ARGS__ 2>&1 | tee $TMP_DIR/test.results'
worker_cmd = f'$(worker {worker})' if worker else ""
if worker_cmd:
test_cmd = f'{worker_cmd} && {test_cmd} '
Expand Down Expand Up @@ -943,6 +943,7 @@ def go_test(name:str, srcs:list, resources:list=None, data:list|dict=None, deps:
pre_build = _collect_linker_flags(static, definitions),
env = env,
provides = provides,
test_cmd_args_placeholder = "__TEST_ARGS__",
)


Expand Down
Loading