Skip to content

Upgrade the Go toolchain, packages and Please plugin - #359

Merged
toastwaffle merged 3 commits into
please-build:masterfrom
toastwaffle:upgrade-all-the-things
Jul 13, 2026
Merged

Upgrade the Go toolchain, packages and Please plugin#359
toastwaffle merged 3 commits into
please-build:masterfrom
toastwaffle:upgrade-all-the-things

Conversation

@toastwaffle

@toastwaffle toastwaffle commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

Mostly a go get -u ./... (after a plz clean -f), followed by go mod tidy and plz puku sync -w, and then fixing stuff.

Comment thread elan/rpc/BUILD
name = "test_data",
cmd = [
'for i in `seq 1 10000`; do echo "$i ----------------------------------------- $i" >> "tmp.txt"; done',
'for i in `seq 1 100000`; do echo "$i ----------------------------------------- $i" >> "tmp.txt"; done',

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some new package caused the test server to return more bytes in a single Recv call, so I had to make the test file bigger

Comment thread elan/rpc/rpc.go
return nil, status.Errorf(codes.NotFound, "write %s not found", req.ResourceName)
}

func (s *server) SpliceBlob(ctx context.Context, req *pb.SpliceBlobRequest) (*pb.SpliceBlobResponse, error) {

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New methods in the proto

@toastwaffle
toastwaffle requested a review from Hamishpk July 13, 2026 08:09

@Hamishpk Hamishpk left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks :)

@toastwaffle
toastwaffle merged commit 2bcbbfe into please-build:master Jul 13, 2026
3 checks passed
@toastwaffle
toastwaffle deleted the upgrade-all-the-things branch July 13, 2026 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants