Open
Conversation
- image upload to crag gallery
- refactoring
demshy
requested changes
Nov 16, 2024
demshy
reviewed
Nov 16, 2024
Contributor
|
maybe have one state variable for each field, and construct form data only before posting to api? |
Contributor
|
multiple progress bar sizes will probably not be needed. I suggest we keep only one that is designed in figma to avoid confusion and possible misuse in the future. if a need for another size arises will be designed later.
from figma: |
Author
|
#56 (comment) @salamca Progress bar font size and padding fixed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Created image upload functionality in crag gallery: