Conversation
|
wohnlice the email address in your commit does not match an email in your GitHub account. Thus it is impossible to determine whether you have signed the Plone Contributor Agreement, which is required to merge this pull request. Learn about the Plone Contributor Agreement: https://plone.org/foundation/contributors-agreement If you have sent in your Plone Contributor Agreement, and received and accepted an invitation to join the Plone GitHub organization, then you might need to either add the email address on your Agreement to your GitHub account or change the email address in your commits. If you need to do the latter, then you should squash the commits with your matching email and push them. Add more emails to your GitHub account: Change the email address in your commits: |
|
@ewohnlich thanks for creating this Pull Request and helping to improve Plone! TL;DR: Finish pushing changes, pass all other checks, then paste a comment: To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically. Happy hacking! |
|
@jenkins-plone-org please run jobs |
|
I added my organization's email to my Github account now, so hopefully that is sufficient for the contributor agreement. wohnlice@imsweb.com and eric.wohnlich@gmail.com are both me, I think I signed with eric.wohnlich@gmail.com but my commits here are coming from wohnlice@imsweb.com. |
|
Is there anything I can do to associate my wohnlice@imsweb.com email (from my commits here) with my eric.wohnlich@gmail.com email (where I signed the agreement) or do I need to sign it again? |
|
@ewohnlich Wouldn't it be easier for you to close this PR and create another branch, committing with the correct email? |
|
Not for the long term, I'll be using this one more. I performed this step already. Can I retrigger that check somehow? Doesn't seem to be automatic |
|
wohnlice the email address in your commit does not match an email in your GitHub account. Thus it is impossible to determine whether you have signed the Plone Contributor Agreement, which is required to merge this pull request. Learn about the Plone Contributor Agreement: https://plone.org/foundation/contributors-agreement If you have sent in your Plone Contributor Agreement, and received and accepted an invitation to join the Plone GitHub organization, then you might need to either add the email address on your Agreement to your GitHub account or change the email address in your commits. If you need to do the latter, then you should squash the commits with your matching email and push them. Add more emails to your GitHub account: Change the email address in your commits: |
|
@ewohnlich thanks for creating this Pull Request and helping to improve Plone! TL;DR: Finish pushing changes, pass all other checks, then paste a comment: To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically. Happy hacking! |
|
@ewohnlich I closed and reopened PR. This usually reruns the jobs. But it's still failing. Are you sure you did the necessary check? Maybe @stevepiercy can help. |
|
@jenkins-plone-org please run jobs |
|
@ewohnlich @wesleybl the message from mister-roboto provides two methods, one of which requires someone to review an updated PCA, and the other can be done by the contributor. |
|
@stevepiercy thanks, but I did do the first option mentioned there already. 
|
|
@ewohnlich The commit email is stored as wohnliche@imsweb.com, not wohnlice@imsweb.com I suggest fixing the email in your local git config and then do a git commit --amend to update the metadata for the existing commit, then force push. |
|
wohnlice the email address in your commit does not match an email in your GitHub account. Thus it is impossible to determine whether you have signed the Plone Contributor Agreement, which is required to merge this pull request. Learn about the Plone Contributor Agreement: https://plone.org/foundation/contributors-agreement If you have sent in your Plone Contributor Agreement, and received and accepted an invitation to join the Plone GitHub organization, then you might need to either add the email address on your Agreement to your GitHub account or change the email address in your commits. If you need to do the latter, then you should squash the commits with your matching email and push them. Add more emails to your GitHub account: Change the email address in your commits: |
|
Thanks @davisagli I think this is fixed. I also added wohnliche@imsweb.com to my email settings (good catch, didn't realize it was using that alias) |
6 participants
As currently written, this package uses pathlib.Path to make operations platform independent. However, this poses a challenge when exporting from a Windows platform and then importing to a Posix platform. Posix platforms do not know how to read Windows paths and will end up trying to create None value Files, and a lot of other errors. This fix proposes to always output paths in the JSON data as Posix. We need to be careful to only do this when writing to the JSON data as we do still need platform specific Paths for a lot of operations - creating files, opening files, checking for existence of files/dirs, etc.
I'm cheating a bit in that I do not attempt to convert Posix paths to whatever platform we're importing on. The reason for this is that Windows already knows how to read Posix paths. Trying to convert it anyway would be tricky, because it's already working as is.