Skip to content

Fix export of remoteUrl to an internal page keeping the site url in the exported data#74

Merged
ericof merged 1 commit into
mainfrom
issue-73
Sep 4, 2025
Merged

Fix export of remoteUrl to an internal page keeping the site url in the exported data#74
ericof merged 1 commit into
mainfrom
issue-73

Conversation

@ericof
Copy link
Copy Markdown
Member

@ericof ericof commented Sep 4, 2025

Closes #73

  • I signed and returned the Plone Contributor Agreement, and received and accepted an invitation to join a team in the Plone GitHub organization.
  • I verified there aren't any other open pull requests for the same change.
  • I followed the guidelines in Contributing to Plone.
  • I successfully ran code quality checks on my changes locally.
  • I successfully ran tests on my changes locally.
  • If needed, I added new tests for my changes.
  • If needed, I added documentation for my changes.
  • I included a change log entry in my commits.

@ericof ericof requested a review from davisagli September 4, 2025 17:24
@mister-roboto
Copy link
Copy Markdown

@ericof thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

@ericof
Copy link
Copy Markdown
Member Author

ericof commented Sep 4, 2025

@jenkins-plone-org please run jobs

@ericof ericof merged commit a5d42db into main Sep 4, 2025
15 of 20 checks passed
@ericof ericof deleted the issue-73 branch September 4, 2025 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Internal Link remoteUrl is exported as http://nohost/Plone/...

3 participants