Skip to content

Support import/export of login_name PAS field #69#76

Merged
mauritsvanrees merged 1 commit into
mainfrom
login_name
Sep 11, 2025
Merged

Support import/export of login_name PAS field #69#76
mauritsvanrees merged 1 commit into
mainfrom
login_name

Conversation

@ewohnlich
Copy link
Copy Markdown
Contributor

@ewohnlich ewohnlich commented Sep 10, 2025

  • I signed and returned the Plone Contributor Agreement, and received and accepted an invitation to join a team in the Plone GitHub organization.
  • I verified there aren't any other open pull requests for the same change.
  • I followed the guidelines in Contributing to Plone.
  • I successfully ran code quality checks on my changes locally.
  • I successfully ran tests on my changes locally.
  • If needed, I added new tests for my changes.
  • If needed, I added documentation for my changes.
  • I included a change log entry in my commits.

If your pull request closes an open issue, include the exact text below, immediately followed by the issue number. When your pull request gets merged, then that issue will close automatically.

Closes Include login_name from acl_users #69

I did not add a new test. Looking at the existing tests, it doesn't seem like it does fine grain tests on user properties. Let me know if I should add one.

@mister-roboto
Copy link
Copy Markdown

@ewohnlich thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

@ewohnlich
Copy link
Copy Markdown
Contributor Author

@jenkins-plone-org please run jobs

Copy link
Copy Markdown
Member

@mauritsvanrees mauritsvanrees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on a standard site, which works, and then on the same site after enabling email as login, and this changes the export in the expected way. Thanks!

@mauritsvanrees mauritsvanrees merged commit 6c339be into main Sep 11, 2025
13 checks passed
@mauritsvanrees mauritsvanrees deleted the login_name branch September 11, 2025 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants