Support import/export of login_name PAS field #69#76
Conversation
|
@ewohnlich thanks for creating this Pull Request and helping to improve Plone! TL;DR: Finish pushing changes, pass all other checks, then paste a comment: To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically. Happy hacking! |
|
@jenkins-plone-org please run jobs |
mauritsvanrees
left a comment
There was a problem hiding this comment.
Tested on a standard site, which works, and then on the same site after enabling email as login, and this changes the export in the expected way. Thanks!
If your pull request closes an open issue, include the exact text below, immediately followed by the issue number. When your pull request gets merged, then that issue will close automatically.
Closes Include login_name from acl_users #69
I did not add a new test. Looking at the existing tests, it doesn't seem like it does fine grain tests on user properties. Let me know if I should add one.