Skip to content

Fix import of ordering inside folderish components#77

Merged
ericof merged 1 commit into
mainfrom
issue-60
Sep 11, 2025
Merged

Fix import of ordering inside folderish components#77
ericof merged 1 commit into
mainfrom
issue-60

Conversation

@ericof
Copy link
Copy Markdown
Member

@ericof ericof commented Sep 11, 2025

Sort ordering metadata by value before applying the ordering to the imported items.

Fixes #60

@ericof ericof added the 01 type: bug something does not work label Sep 11, 2025
@mister-roboto
Copy link
Copy Markdown

@ericof thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

@ericof ericof requested a review from pbauer September 11, 2025 14:47
@ericof
Copy link
Copy Markdown
Member Author

ericof commented Sep 11, 2025

@jenkins-plone-org please run jobs

Copy link
Copy Markdown
Member

@mauritsvanrees mauritsvanrees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried this on the site where I experienced the problem. With a fresh site created from the distribution, if I export it, there are no changes in __metadata__.json in the ordering key.
So it works. Thanks!

@ericof ericof merged commit e8ab1a5 into main Sep 11, 2025
12 of 13 checks passed
@ericof ericof deleted the issue-60 branch September 11, 2025 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

01 type: bug something does not work

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Folder ordering is not correctly imported

4 participants