Conversation
|
@ericof thanks for creating this Pull Request and helping to improve Plone! TL;DR: Finish pushing changes, pass all other checks, then paste a comment: To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically. Happy hacking! |
|
@jenkins-plone-org please run jobs |
mauritsvanrees
left a comment
There was a problem hiding this comment.
This is fine and can be merged.
But I would use latest plone.meta and its test matrix, so we can test on all supported Plone and Python version combinations. Locally, the tests with Plone 6.2 Python 3.13 pass for me.
Did you run config_package.py from plone meta for this? If so, then I think you are using the main branch. You should use the 2.x branch instead. This is actually newer than the main branch.
@gforcada, if that is indeed the problem, I wonder if we should make a change on the main branch to give an error or warning when running config_package.
BTW Erico, this package is not tested on Jenkins, so there is no need to run Jenkins jobs.
|
@mauritsvanrees I've tagged @gforcada to get his attention to plone/meta (as I did not run the latest version) |
Package metadata updates:
Closes #78