Skip to content

Typo#85

Merged
davisagli merged 1 commit into
mainfrom
gforcada-patch-2
Feb 5, 2026
Merged

Typo#85
davisagli merged 1 commit into
mainfrom
gforcada-patch-2

Conversation

@gforcada
Copy link
Copy Markdown
Member

@ericof are IExporter and INamedExporter meant to have the same docstring as well? And likewise for their importer counterparts? :)

@gforcada gforcada self-assigned this Dec 17, 2025
@mister-roboto
Copy link
Copy Markdown

@gforcada thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

@gforcada gforcada requested a review from ericof December 17, 2025 10:55
@ericof
Copy link
Copy Markdown
Member

ericof commented Dec 17, 2025

Of course not, but things like that happen during a sprint 😉
Also, we need a changelog entry

@davisagli
Copy link
Copy Markdown
Member

I'm going to make the call that a release note for this would be more noise than signal.

@davisagli davisagli merged commit 81833d8 into main Feb 5, 2026
9 of 12 checks passed
@davisagli davisagli deleted the gforcada-patch-2 branch February 5, 2026 01:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants