Skip to content

Config with default template 2.8.1.dev0 plone.meta#94

Merged
mauritsvanrees merged 4 commits into
mainfrom
config-with-default-template-2.8.1.dev0
May 19, 2026
Merged

Config with default template 2.8.1.dev0 plone.meta#94
mauritsvanrees merged 4 commits into
mainfrom
config-with-default-template-2.8.1.dev0

Conversation

@mauritsvanrees
Copy link
Copy Markdown
Member

@mauritsvanrees mauritsvanrees commented May 18, 2026

  • Configure with plone.meta.
  • Fix error for an invalid workflow file.
  • Run black/isort/pyupgrade: remove typing imports for unsupported Python versions

This is because the Python 3.8/3.9 way of defining typing is no longer needed.
So remove unused typing imports.
Our override removed the circular job, which is probably fine to add back.
And it added the `test` job, which no longer exists on plone.meta (that is what `test-matrix.yml` is for).
@mauritsvanrees mauritsvanrees requested a review from ericof May 18, 2026 21:07
@mister-roboto

This comment was marked as resolved.

Copy link
Copy Markdown
Member

@ericof ericof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mauritsvanrees mauritsvanrees merged commit ea1b1b6 into main May 19, 2026
9 of 11 checks passed
@mauritsvanrees mauritsvanrees deleted the config-with-default-template-2.8.1.dev0 branch May 19, 2026 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants