-
Notifications
You must be signed in to change notification settings - Fork 130
fix: backslashes in translations not working in textarea #3575
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
stonebuzz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems good for me (please note that this problem only occurs on textarea)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change might break setting default values for multiselect questions. To secure the patch i would recommend to check the question type before calling str_replace.
Changes description
This PR corrects the translation problem if the text of a textarea to translate contains backslashes
Original :

Translation :

Checklist
Please check if your PR fulfills the following specifications:
Closes !36722