Skip to content

Conversation

@MyvTsv
Copy link

@MyvTsv MyvTsv commented Mar 7, 2025

Changes description

This PR corrects the translation problem if the text of a textarea to translate contains backslashes

Original :
Capture d’écran du 2025-03-07 10-35-19

Translation :
Capture d’écran du 2025-03-07 10-34-34

Checklist

Please check if your PR fulfills the following specifications:

  • Tests for the changes have been added
  • Docs have been added/updated

Closes !36722

@MyvTsv MyvTsv requested review from Rom1-B and stonebuzz March 7, 2025 09:42
@MyvTsv MyvTsv self-assigned this Mar 7, 2025
@stonebuzz stonebuzz requested a review from btry March 7, 2025 09:46
Copy link
Contributor

@stonebuzz stonebuzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems good for me (please note that this problem only occurs on textarea)

Copy link
Collaborator

@btry btry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change might break setting default values for multiselect questions. To secure the patch i would recommend to check the question type before calling str_replace.

@MyvTsv MyvTsv requested review from Rom1-B, btry and stonebuzz March 7, 2025 11:47
@stonebuzz stonebuzz self-requested a review March 7, 2025 13:29
@Rom1-B Rom1-B merged commit 201e28d into pluginsGLPI:support/2.13.0 Mar 7, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants