Skip to content

Conversation

@RomainLvr
Copy link

Changes description

Checklist

Please check if your PR fulfills the following specifications:

  • Tests for the changes have been added
  • Docs have been added/updated

Restore save button disappeared from fix : glpi-project/glpi#18286

Capture d’écran du 2025-03-12 10-38-58

@RomainLvr RomainLvr requested review from Rom1-B and stonebuzz March 12, 2025 09:40
@RomainLvr RomainLvr self-assigned this Mar 12, 2025
@btry
Copy link
Collaborator

btry commented Mar 12, 2025

Hi

Why is it needed to show the save button here ? The user must accept / refuse or edit the form answer here.

@RomainLvr
Copy link
Author

Hi

Why is it needed to show the save button here ? The user must accept / refuse or edit the form answer here.

The client uses this button to add comments for other validators. A kind of note to let other validators know that the form is being processed, or that sort of thing.

@btry
Copy link
Collaborator

btry commented Mar 12, 2025

The user who access this page is already a validator, and the plugin is designed to have a validation by a single valdiator. If several users can validate a form answer, only one of them has to take a decision.

@RomainLvr
Copy link
Author

The user who access this page is already a validator, and the plugin is designed to have a validation by a single valdiator. If several users can validate a form answer, only one of them has to take a decision.

Yes, only one validator can validate, but each validator can leave his opinion via the comment field before the final decision.

@RomainLvr RomainLvr closed this Mar 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants