Skip to content

Fix(Dashboard): fix pending and to be validated counter #3584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stonebuzz merged 1 commit into from
Apr 15, 2025
Merged

Fix(Dashboard): fix pending and to be validated counter #3584

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions hook.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -309,6 +309,10 @@ function plugin_formcreator_addWhere($link, $nott, $itemtype, $ID, $val, $search
$tocheck = $item->getPendingStatusArray();
break;

case PluginFormcreatorFormAnswer::STATUS_WAITING:
$tocheck = $item->getPendingValidationStatusArray();
break;

case Ticket::CLOSED:
$tocheck = $item->getClosedStatusArray();
break;
Expand Down
6 changes: 3 additions & 3 deletions inc/formanswer.class.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,9 +75,9 @@ class PluginFormcreatorFormAnswer extends CommonDBTM

public static function getStatuses() {
return [
self::STATUS_WAITING => __('Waiting', 'formcreator'),
self::STATUS_REFUSED => __('Refused', 'formcreator'),
self::STATUS_ACCEPTED => __('Accepted', 'formcreator'),
self::STATUS_WAITING => __('To validate', 'formcreator'),
self::STATUS_REFUSED => __('Validation Refused', 'formcreator'),
self::STATUS_ACCEPTED => __('Validation Accepted', 'formcreator'),
];
}

Expand Down
6 changes: 5 additions & 1 deletion inc/issue.class.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1135,7 +1135,11 @@ static function getNewStatusArray() {
}

static function getPendingStatusArray() {
return [Ticket::WAITING, PluginFormcreatorFormAnswer::STATUS_WAITING];
return [Ticket::WAITING];
}

static function getPendingValidationStatusArray() {
return [PluginFormcreatorFormAnswer::STATUS_WAITING];
}

static function getProcessStatusArray() {
Expand Down