Open
Conversation
Contributor
segef
commented
Mar 28, 2026
segef
commented
- A new script is introduced that saves the EC to TPS substrate mapping to a json
- CLEAN evaluation logic is updated to use the propagated json file
…mbers. The final prediction scores are calculated by a weighted majority voting.
SamusRam
added a commit
that referenced
this pull request
Apr 7, 2026
Merge PR #34 (bugfix/fix_clean_ec_to_substrate_mapping): - Replace Rhea-based EC lookup with pre-computed JSON mapping - Add fold-specific pretrained model support (fold_idx parameter) - Add weighted majority voting for isTPS/substrate prediction - Add ec_utils.py, clean_dataset_prep.py, get_ec_to_substrate_mapping.py - Add fold_idx parameter to all predict_proba signatures - Update all CLEAN/CLEANEcDetection/CLEANBetterDetection configs Fix _NON_TPS_LABELS: - Remove 'other' from the set so proteins with 'other' substrate are correctly labeled as TPS-positive (isTPS=True) - Update tests accordingly Made-with: Cursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.