Skip to content

Updated zh-rCN (Chinese (China)) translation - #19

Open
Crystal-RainSlide wants to merge 3 commits into
pmarks-net:masterfrom
Crystal-RainSlide:master
Open

Updated zh-rCN (Chinese (China)) translation #19
Crystal-RainSlide wants to merge 3 commits into
pmarks-net:masterfrom
Crystal-RainSlide:master

Conversation

@Crystal-RainSlide

Copy link
Copy Markdown

Everything should be OK this time.

<string name="stop_reason_notification">已通过通知栏按钮停止</string>
<string name="stop_reason_toolbar">已通过工具栏按钮停止</string>
<string name="stop_reason_mediabutton">已通过媒体按钮停止播放</string>
<string name="stop_reason_silent">Exited while silent</string>

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are two of the strings still in English? I'm not able to judge the quality of these translations directly, but missing two is just weird. Were these done by a human, or a bot?

I'm hesitant to accept additional languages into the codebase because it creates a black box that I won't be able to maintain. I've tried to make the app's basic functionality primarily graphical, in order to avoid this problem.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure what is those two stop reason. What does "silent" mean? And why it can be stoped by a restart?

As those two should be rarely seen, I had better keep them still.

I'll keep update this easily by Stringlate though Stringlate is not perfect, and if I can't update this, just keep this file still, Android's i18n will handle everything and untranslated new parts are acceptable by the majority.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants