Skip to content
This repository was archived by the owner on Mar 22, 2023. It is now read-only.

Conversation

@karczex
Copy link

@karczex karczex commented Dec 9, 2019

This change is Reviewable

@pmem-bot
Copy link

pmem-bot commented Dec 9, 2019

@szyrom and @ldorau please review this pull request

Copy link
Member

@lukaszstolarczuk lukaszstolarczuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

Copy link
Member

@ldorau ldorau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @karczex)


test/database_spec.js, line 332 at r1 (raw file):

             db.get_keys_below('B', ex);
        } catch (e) {
            expect(e.message).to.equal('TestException');

This test fails ... ?

@karczex
Copy link
Author

karczex commented Dec 19, 2019


test/database_spec.js, line 332 at r1 (raw file):

Previously, ldorau (Lukasz Dorau) wrote…

This test fails ... ?

Yes, it fails. It's test for this issue #51

Copy link
Member

@ldorau ldorau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @karczex)


test/database_spec.js, line 332 at r1 (raw file):

Previously, karczex wrote…

Yes, it fails. It's test for this issue #51

So when this test will not fail?

@karczex
Copy link
Author

karczex commented Dec 19, 2019


test/database_spec.js, line 332 at r1 (raw file):

Previously, ldorau (Lukasz Dorau) wrote…

So when this test will not fail?

I don't know.

Copy link
Member

@ldorau ldorau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @karczex)


test/database_spec.js, line 332 at r1 (raw file):

Previously, karczex wrote…

I don't know.

Ah, so this PR just waits for a fix?

@karczex
Copy link
Author

karczex commented Dec 19, 2019


test/database_spec.js, line 332 at r1 (raw file):

Previously, ldorau (Lukasz Dorau) wrote…

Ah, so this PR just waits for a fix?

Yes, it's bug reproducer. Unfortunately build system doesn't support tests which are failing. I think this PR may stay as draft until fixed.

Copy link
Member

@ldorau ldorau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @karczex)


test/database_spec.js, line 332 at r1 (raw file):

Previously, karczex wrote…

Yes, it's bug reproducer. Unfortunately build system doesn't support tests which are failing. I think this PR may stay as draft until fixed.

I see, OK

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants