feat: person connections (non-family relationships)#541
Merged
Conversation
Adds a formal mechanism to track non-family relationships between people (friend, colleague, neighbor, employer/employee, godparent/ godchild, other) with optional notes and year range. - Migration v40: person_connections table with canonical ordering constraint (person_id_1 < person_id_2) to prevent duplicate pairs - GraphQL schema: PersonConnection type, PersonConnectionInput, connections field on Person, add/update/remove mutations - DataLoader: batchConnections fans rows to both participants - PersonConnection.person resolver uses _viewerId to return the other person in the connection - PersonConnectionsCard UI component with person search, type select, notes and year range fields Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Moving connections out of GET_PERSON prevents the CI test DB (which doesn't run migrations) from breaking the whole person page when the person_connections table doesn't yet exist. The card now owns its own GET_PERSON_CONNECTIONS query, mirroring how CommentsSection works. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
PageHeader already renders an h1 for the page title; having a second h1 in the hero card is invalid HTML and breaks the Playwright strict-mode locator that expects a single h1. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
person_connectionstable (migration v40) to track non-family relationships between people: friend, colleague, neighbor, employer/employee, godparent/godchild, otherperson_id_1 < person_id_2) prevents duplicate pairs; unique index on(person_id_1, person_id_2, connection_type)connectionsfield on Person,addPersonConnection/updatePersonConnection/removePersonConnectionmutationsPersonConnectionsCardUI component on the person detail page — person picker, type dropdown, optional notes + year rangeTest plan
runMigrationsmutation) after deploy — verifyperson_connectionstable is createdec17fbacd297) to Pete's dad (Peter Eugene Milanese,pnYxTBXi2HZP) as "friend"🤖 Generated with Claude Code