test: API 요청 함수 테스트 구현 #49
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmmm114
added
size/large
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
- createTarotRequest 함수 테스트 (검증 포함) - getTarotRequestStatus 함수 테스트 - cancelTarotRequest 함수 테스트 - HTTP 클라이언트 싱글톤 테스트 - 포괄적인 데이터 검증 테스트
pmmm114
force-pushed
the
feature/tarote.api-request-tests
branch
from
dd01f22 to
f3030d4
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
This is the final PR Bugbot will review for you during this billing cycle
Your free Bugbot reviews will reset on October 27
Details
You are on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
| const validRequestData: TarotRequestData = { | ||
| question: '나의 미래는 어떨까요?', | ||
| selectedCards: [1, 15, 42] | ||
| }; |
There was a problem hiding this comment.
Bug: Duplicate Constant Declaration Causes Error
The validRequestData constant is declared twice, with one declaration at the end of the file appearing after its use in the 'HTTP 클라이언트 싱글톤' tests. This causes a ReferenceError due to const declarations not being hoisted. The duplicate declaration also introduces redundancy.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
API 요청 함수 테스트 구현 (231 lines) - 포괄적인 데이터 검증 및 싱글톤 테스트로 모든 API 함수 동작 검증
Changes
requests.test.ts: API 요청 함수 테스트 슈트Test plan
변경 유형: test
변경 규모: large
영향 범위: frontend