Skip to content

feat: handle touch start/end events as pointer over/out#46

Open
milesflavel wants to merge 3 commits intopmndrs:mainfrom
milesflavel:feat/handle-touch-events
Open

feat: handle touch start/end events as pointer over/out#46
milesflavel wants to merge 3 commits intopmndrs:mainfrom
milesflavel:feat/handle-touch-events

Conversation

@milesflavel
Copy link
Collaborator

  • refactor: separate A11y state into 3 separate state variables
  • feat: handle touch start/end events as pointer over/out

Partially resolves #45 (comment)

@AlaricBaraou
Copy link
Collaborator

@milesflavel Do you mind explaining why we need onTouchStart / onTouchEnd ?
I'm fine with the other changes of this PR

@milesflavel
Copy link
Collaborator Author

@milesflavel Do you mind explaining why we need onTouchStart / onTouchEnd ? I'm fine with the other changes of this PR

I was running into situations where touch would result in the hovered state being set true, but it would never set itself false again. By explicitly binding the onTouchStart & onTouchEnd events, it resolved this problem.

The issues were loosely described in #45

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Touch events behave inconsistently with A11y

2 participants