Skip to content

perf: replace O(n²) spread with push in smarkets fetcher #616

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
realfishsam merged 1 commit into from
May 24, 2026
Merged

perf: replace O(n²) spread with push in smarkets fetcher #616

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 14 additions & 6 deletions core/src/exchanges/smarkets/fetcher.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -403,14 +403,22 @@ export class SmarketsFetcher implements IExchangeFetcher<SmarketsRawEventWithMar

const marketsByEvent = new Map<string, SmarketsRawMarket[]>();
for (const market of allMarkets) {
const existing = marketsByEvent.get(market.event_id) || [];
marketsByEvent.set(market.event_id, [...existing, market]);
const existing = marketsByEvent.get(market.event_id);
if (existing) {
existing.push(market);
} else {
marketsByEvent.set(market.event_id, [market]);
}
}

const contractsByMarket = new Map<string, SmarketsRawContract[]>();
for (const contract of allContracts) {
const existing = contractsByMarket.get(contract.market_id) || [];
contractsByMarket.set(contract.market_id, [...existing, contract]);
const existing = contractsByMarket.get(contract.market_id);
if (existing) {
existing.push(contract);
} else {
contractsByMarket.set(contract.market_id, [contract]);
}
}

const volumesByMarket = new Map<string, SmarketsRawVolume>();
Expand Down Expand Up @@ -443,7 +451,7 @@ export class SmarketsFetcher implements IExchangeFetcher<SmarketsRawEventWithMar
queryParams: Record<string, any>,
targetCount?: number
): Promise<SmarketsRawEvent[]> {
let allEvents: SmarketsRawEvent[] = [];
const allEvents: SmarketsRawEvent[] = [];
let lastId: string | undefined;
let page = 0;

Expand All @@ -461,7 +469,7 @@ export class SmarketsFetcher implements IExchangeFetcher<SmarketsRawEventWithMar
const events: SmarketsRawEvent[] = data.events || [];
if (events.length === 0) break;

allEvents = [...allEvents, ...events];
allEvents.push(...events);

// Check pagination: next_page is null when there are no more results
const nextPage = data.pagination?.next_page;
Expand Down
Loading