Skip to content

fix: catch JSON.parse in ws-client onmessage #626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
realfishsam merged 1 commit into from
May 24, 2026
Merged

fix: catch JSON.parse in ws-client onmessage #626

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 13 additions & 2 deletions sdks/typescript/pmxt/ws-client.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,8 +129,19 @@ export class SidecarWsClient {
const raw = typeof event.data === "string"
? event.data
: event.data.toString();
const msg: WsMessage = JSON.parse(raw);
this.dispatch(msg);
let msg: WsMessage;
try {
msg = JSON.parse(raw);
} catch {
// Non-JSON control frame -- ignore.
return;
}
try {
this.dispatch(msg);
} catch (err) {
// Dispatch bug -- log and continue; don't kill the connection.
console.error('[SidecarWsClient] dispatch error:', err);
}
};
});
}
Expand Down
Loading