arm: avoid overflow in RGBA palette offset - #899
Open
soul-sol wants to merge 1 commit into
Open
Conversation
Signed-off-by: solim <7576268+soul-sol@users.noreply.github.com>
Contributor
|
Hum. As I implied in the comments I just attempted to preserve the "original code" bugs and all. At this point the code requires a maintainer. Maintainer, step forward. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Promote
row_widthtosize_tbefore multiplying it by the four-byte RGBA pixel size in the ARM NEON palette expansion path.Without the promotion,
4 * row_widthis evaluated as 32-bit unsigned arithmetic and wraps for widths greater thanUINT32_MAX / 4. This matches the existing ARM NEON RGB path and the scalar RGBA implementation.Fixes #862.
Verification
3forrow_width = 1,073,741,825, while the promoted expression yields4,294,967,299.pngsimd.cwith Clang as an ARM64 Mach-O object using-Wall -Wextra -Werror.git diff --checkpasses.